Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.1 #129

Merged
merged 109 commits into from
Oct 13, 2023
Merged

1.1 #129

merged 109 commits into from
Oct 13, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 20, 2022

workerB

cleder and others added 20 commits September 29, 2022 09:07
@cleder
Merge pull request #120 from cleder/main
51cc97f 
Merge pull request #116 from cleder/develop
@cleder
back to development
0451929
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
208e992 
updates:
- [github.com/regebro/pyroma: 3.2 → 4.0](regebro/pyroma@3.2...4.0)
@cleder
Merge pull request #121 from cleder/pre-commit-ci-update-config
393bf20 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
7725946 
updates:
- [github.com/psf/black: 22.8.0 → 22.10.0](psf/black@22.8.0...22.10.0)
- [github.com/pre-commit/mirrors-mypy: v0.981 → v0.982](pre-commit/mirrors-mypy@v0.981...v0.982)
@cleder
Merge pull request #122 from cleder/pre-commit-ci-update-config
4ad5a9e 
[pre-commit.ci] pre-commit autoupdate
@dependabot
Bump actions/setup-node from 3.5.0 to 3.5.1
50f844e 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.0 to 3.5.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.5.0...v3.5.1)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@cleder
Merge pull request #123 from cleder/dependabot/github_actions/actions…
986d4d4 
…/setup-node-3.5.1

Bump actions/setup-node from 3.5.0 to 3.5.1
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
fbba13c 
updates:
- [github.com/python-jsonschema/check-jsonschema: 0.18.3 → 0.18.4](python-jsonschema/check-jsonschema@0.18.3...0.18.4)
@cleder
Merge pull request #124 from cleder/pre-commit-ci-update-config
21c39d3 
[pre-commit.ci] pre-commit autoupdate
@cleder
test 3.11 final
4501237
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
33c7d8e 
updates:
- [github.com/hakancelikdev/unimport: 0.12.1 → 0dc8d609eb670eeb3335958acddcb6059cc4b8dd](hakancelikdev/unimport@0.12.1...0dc8d60)
@cleder
Merge pull request #125 from cleder/pre-commit-ci-update-config
0bd26cf 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
320f5bd 
updates:
- [github.com/hakancelikdev/unimport: 0dc8d609eb670eeb3335958acddcb6059cc4b8dd → a56235171fc28dff6a879c377bb7392679552671](hakancelikdev/unimport@0dc8d60...a562351)
@cleder
Merge pull request #126 from cleder/pre-commit-ci-update-config
9797532 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
5af7c71 
updates:
- [github.com/hakancelikdev/unimport: a56235171fc28dff6a879c377bb7392679552671 → 004b5dd0c8112330275beb52c4ccfce016a4b945](hakancelikdev/unimport@a562351...004b5dd)
- [github.com/pre-commit/mirrors-mypy: v0.982 → v0.990](pre-commit/mirrors-mypy@v0.982...v0.990)
- [github.com/python-jsonschema/check-jsonschema: 0.18.4 → 0.19.1](python-jsonschema/check-jsonschema@0.18.4...0.19.1)
@cleder
Merge pull request #127 from cleder/pre-commit-ci-update-config
36d660c 
[pre-commit.ci] pre-commit autoupdate
@cleder
add python 3.12 to test matrix
23332d4
@cleder
auto remove print statements
be3ced0
@cleder
autoupdate
93da7d9
@what-the-diff
Copy link

what-the-diff bot commented Nov 20, 2022

  • 1 (unreleased)

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 20, 2022 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 1.25 ⭐ 1.25 ⭐ 0.00
Method Length 35.31 ⭐ 35.28 ⭐ -0.03 👍
Working memory 5.49 ⭐ 5.49 ⭐ 0.00
Quality 85.01% ⭐ 85.02% ⭐ 0.01% 👍
Other metrics Before After Change
Lines 1574 1579 5
Changed files Quality Before Quality After Quality Change
setup.py 86.62% ⭐ 86.62% ⭐ 0.00%
pygeoif/__init__.py 83.69% ⭐ 83.69% ⭐ 0.00%
pygeoif/exceptions.py 98.33% ⭐ 98.33% ⭐ 0.00%
pygeoif/factories.py 77.34% ⭐ 77.40% ⭐ 0.06% 👍
pygeoif/feature.py 91.41% ⭐ 91.41% ⭐ 0.00%
pygeoif/functions.py 79.33% ⭐ 79.33% ⭐ 0.00%
pygeoif/geometry.py 90.49% ⭐ 90.48% ⭐ -0.01% 👎
pygeoif/types.py 56.94% 🙂 56.94% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pygeoif/factories.py _shell_holes_from_wkt_coords 2 ⭐ 75 🙂 10 😞 70.60% 🙂 Extract out complex expressions
pygeoif/factories.py from_wkt 2 ⭐ 122 😞 6 ⭐ 73.22% 🙂 Try splitting into smaller methods
pygeoif/factories.py _multiline_from_wkt_coordinates 0 ⭐ 48 ⭐ 11 😞 74.91% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fc19141) 100.00% compared to head (db0f50f) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2107      2134   +27     
=========================================
+ Hits          2107      2134   +27
Impacted Files Coverage Δ
pygeoif/__init__.py 100.00% <ø> (ø)
pygeoif/exceptions.py 100.00% <ø> (ø)
pygeoif/feature.py 100.00% <ø> (ø)
pygeoif/geometry.py 100.00% <ø> (ø)
pygeoif/types.py 100.00% <ø> (ø)
tests/test_base.py 100.00% <ø> (ø)
tests/test_bounds.py 100.00% <ø> (ø)
tests/test_factories.py 100.00% <ø> (ø)
tests/test_feature.py 100.00% <ø> (ø)
tests/test_functions.py 100.00% <ø> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sourcery-ai sourcery-ai bot mentioned this pull request Nov 20, 2022
Closed
@ghost
Copy link

ghost commented Nov 20, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder marked this pull request as draft November 20, 2022 14:06
pre-commit-ci bot and others added 3 commits November 21, 2022 16:44
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
1e00466 
updates:
- [github.com/python-jsonschema/check-jsonschema: 0.19.1 → 0.19.2](python-jsonschema/check-jsonschema@0.19.1...0.19.2)
@cleder
Merge pull request #131 from cleder/pre-commit-ci-update-config
52783c6 
[pre-commit.ci] pre-commit autoupdate
'Refactored by Sourcery'
ad8d362
pre-commit-ci bot and others added 28 commits July 24, 2023 16:58
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
a375076 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.278 → v0.0.280](astral-sh/ruff-pre-commit@v0.0.278...v0.0.280)
@cleder
Merge pull request #161 from cleder/pre-commit-ci-update-config
085dcd0 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
be5fcc9 
updates:
- https://github.com/ikamensh/flynt/: 1.0.0 → 1.0.1
- [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0)
@cleder
Merge pull request #162 from cleder/pre-commit-ci-update-config
7b7cb17 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
0dfad1a 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.280 → v0.0.282](astral-sh/ruff-pre-commit@v0.0.280...v0.0.282)
@cleder
Merge pull request #163 from cleder/pre-commit-ci-update-config
7a734a0 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
10f307b 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.282 → v0.0.286](astral-sh/ruff-pre-commit@v0.0.282...v0.0.286)
- [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1)
- [github.com/python-jsonschema/check-jsonschema: 0.23.3 → 0.26.3](python-jsonschema/check-jsonschema@0.23.3...0.26.3)
@cleder
Merge pull request #164 from cleder/pre-commit-ci-update-config
01b6c30 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
688e385 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.286 → v0.0.287](astral-sh/ruff-pre-commit@v0.0.286...v0.0.287)
@dependabot
Bump actions/checkout from 3 to 4
83e5c83 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@cleder
Merge pull request #165 from cleder/pre-commit-ci-update-config
46a8187 
[pre-commit.ci] pre-commit autoupdate
@cleder
Merge pull request #166 from cleder/dependabot/github_actions/actions…
99e6219 
…/checkout-4

Bump actions/checkout from 3 to 4
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
88d785a 
updates:
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)
@dependabot
Bump codecov/codecov-action from 3 to 4
16084c1 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@cleder
Merge pull request #168 from cleder/dependabot/github_actions/codecov…
eca2c5f 
…/codecov-action-4

Bump codecov/codecov-action from 3 to 4
@cleder
Merge pull request #167 from cleder/pre-commit-ci-update-config
85098c7 
[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
8cd8bef 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.287 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.287...v0.0.292)
- [github.com/python-jsonschema/check-jsonschema: 0.26.3 → 0.27.0](python-jsonschema/check-jsonschema@0.26.3...0.27.0)
@cleder
Merge pull request #169 from cleder/pre-commit-ci-update-config
29fd591 
[pre-commit.ci] pre-commit autoupdate
@cleder
raise dimension error
09b0435
@cleder
add test for nested multigeometries
0b322cf
@cleder
Fix __eq__ for nested Geometrycollections
c2770ac
@cleder
add missing test
b2e6603
@cleder
add pypy 3.10 to test matrix
599b802
@cleder
fix tests
8221213
@cleder
better support for nested multi geometries
c496183
@cleder
improve typing and tests
4372e39
@cleder
prepare release
8d43344
@cleder
correct version in setup.py
3b9c91a
@cleder cleder marked this pull request as ready for review October 13, 2023 15:56
@cleder cleder merged commit be7fecf into main Oct 13, 2023
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cleder